Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update test_factorization_machines.py #35

Open
wants to merge 19 commits into
base: master-workflows
Choose a base branch
from
Open

Update test_factorization_machines.py #35

wants to merge 19 commits into from

Conversation

benieric
Copy link
Owner

Issue #, if available:

Description of changes:

Testing done:

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

  • I have read the CONTRIBUTING doc
  • I certify that the changes I am introducing will be backward compatible, and I have discussed concerns about this, if any, with the Python SDK team
  • I used the commit message format described in CONTRIBUTING
  • I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
  • I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes
  • I have checked that my tests are not configured for a specific region or account (if appropriate)
  • I have used unique_name_from_base to create resource names in integ tests (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

benieric
benieric commented Jul 30, 2024
View reviewed changes
Copy link
Owner Author

@benieric benieric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/run slow

benieric
benieric commented Jul 30, 2024
View reviewed changes
Copy link
Owner Author

@benieric benieric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/run localmode

benieric
benieric commented Jul 30, 2024
View reviewed changes
Copy link
Owner Author

@benieric benieric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/run localmode

benieric
benieric commented Jul 30, 2024
View reviewed changes
Copy link
Owner Author

@benieric benieric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/run slow

benieric
benieric commented Jul 30, 2024
View reviewed changes
Copy link
Owner Author

@benieric benieric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test comment

benieric
benieric commented Jul 30, 2024
View reviewed changes
Copy link
Owner Author

@benieric benieric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/run slow

benieric
benieric commented Jul 30, 2024
View reviewed changes
Copy link
Owner Author

@benieric benieric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/run slow

benieric
benieric commented Jul 30, 2024
View reviewed changes
Copy link
Owner Author

@benieric benieric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/run slow

benieric
benieric commented Jul 30, 2024
View reviewed changes
Copy link
Owner Author

@benieric benieric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/run localmode

benieric
benieric commented Jul 30, 2024
View reviewed changes
Copy link
Owner Author

@benieric benieric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/run slow

benieric
benieric commented Jul 30, 2024
View reviewed changes
Copy link
Owner Author

@benieric benieric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/run slow

@benieric benieric force-pushed the master-workflows branch 2 times, most recently from 68745ae to 56aa1ad Compare July 30, 2024 09:10
@benieric benieric deployed to auto-approve July 30, 2024 09:11 — with GitHub Actions Active
benieric
benieric commented Jul 30, 2024
View reviewed changes
Copy link
Owner Author

@benieric benieric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/slow test

benieric
benieric commented Jul 30, 2024
View reviewed changes
Copy link
Owner Author

@benieric benieric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/run slow

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@benieric