Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker Image #262

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Docker Image #262

wants to merge 1 commit into from

Conversation

foosinn
Copy link

@foosinn foosinn commented Jan 8, 2021

This provides a Docker image for bepasty.

Goals:

  • run as unprivileged user
  • no write access to config
  • tries to be simple
  • basic configuration via environment variables
  • extended configuration via file mount

I'm not entirely sure if a Docker image is wanted. Neither found one in the repository nor the issues.

@codecov-io
Copy link

codecov-io commented Jan 8, 2021

Codecov Report

Merging #262 (528c9bf) into master (f4f8d97) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #262   +/-   ##
=======================================
  Coverage   71.38%   71.38%           
=======================================
  Files          44       44           
  Lines        2558     2558           
=======================================
  Hits         1826     1826           
  Misses        732      732           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f4f8d97...528c9bf. Read the comment docs.

@foosinn foosinn force-pushed the docker branch 4 times, most recently from 89712b5 to 528c9bf Compare January 8, 2021 22:48
@ThomasWaldmann
Copy link
Contributor

can somebody who is familiar with docker please review this?

@duchenpaul
Copy link

This is nice, please merge this PR

@ThomasWaldmann
Copy link
Contributor

@duchenpaul so you practically tried it?

Copy link
Contributor

@ThomasWaldmann ThomasWaldmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

had a quick look, some feedback/questions.

docker/README.md Outdated Show resolved Hide resolved
docker/Dockerfile Outdated Show resolved Hide resolved
docker/Dockerfile Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented May 23, 2023

Codecov Report

Merging #262 (14a165e) into master (f4f8d97) will decrease coverage by 1.05%.
The diff coverage is n/a.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##           master     #262      +/-   ##
==========================================
- Coverage   71.38%   70.33%   -1.05%     
==========================================
  Files          44       44              
  Lines        2558     2623      +65     
==========================================
+ Hits         1826     1845      +19     
- Misses        732      778      +46     

see 13 files with indirect coverage changes

@Ilosariph
Copy link

A docker image would bi amazing, is there any plan for this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants