-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated Create Pool Flow with Presets #246
base: v2
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
9 Skipped Deployments
|
…meters and using the existing Dynamic Preview to actually create the pool and do approvals.
…wise display of the error be handled within useLiquidityMismatch hook
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please, clean it up a bit and review all copy and titles with the one on figma. I think they changed but no one told you. You can double check
function showStep(previewStep: number) { | ||
// NOTE: if switched to using an ENUM / Map for steps we could do something more intelligent here. | ||
return completedSteps.includes(previewStep); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please let's switch to enum, this index usage is a lil messy
}); | ||
|
||
const getStepVerification = (): { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's move this into another file pls
} | ||
}; | ||
|
||
// import { gql } from "@apollo/client"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we can't have references to the chain name in the codebase, please use the variable.
Can you pls share the error in dm? I'd like to help u, we can't merge the pr with hardcoded query
return { | ||
...swrResponse, | ||
refresh: () => void swrResponse.mutate(), | ||
// FIXME we should probably have a polling rate so this expires? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you might even use useSWRImmutable, whitelisting can only change with a governance proposal
return { | ||
...swrResponse, | ||
refresh: () => void swrResponse.mutate(), | ||
// FIXME we should probably have a polling rate so this expires? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for sure i wouldnt poll it on interval, and you might disable revalidateOnFocus too
packages/config/tailwind/index.ts
Outdated
createButton: "#e6b434", | ||
processStepBackground: "#373332", | ||
highlight: "#0284C7", | ||
semanticSuccessForeground: "#4ADE80", | ||
semanticSuccessBackground: "#141D10", | ||
semanticBlueSuccessForeground: "#38BCF8", | ||
semanticBlueSuccessBackground: "#121A1C", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we cannot have new ds styles in this PR. please use legacy styles
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
responding here since I cant reply to the other comments:
- RE the polling, I think we probably need to since this is specifically price data we are fetching (I think maybe you confused this SWR with the one in the whitelisted BGT PR 👀 ), so I've set it to SLOW (3mins)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
RE: ds styles, reverted back to green styling like in existing code 👍
…rect fetch from the codebase + Poll for bex api prices on a slow rate
…t and into utils/constants
{titles.map((title, index) => ( | ||
<div | ||
key={index} | ||
title={(isStepSelectable(index) && verifiedSteps.errors[index]) || ""} | ||
className={cn( | ||
"relative", | ||
"relative w-full", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe worth running w-full by bobby/neph @bearpong ?
we had originally agreed to tile the steps so they might be surprised by w-full on each card
…n Preset it wasn't updating the display inside the Advanced accordion
This has the updated Amplification Parameter preset flow for stable pools, updated progression and summary sidebars.
What isn't in this PR is an in-page tx (it still uses a DynamicPreview modal), we'll do that in BFE-410: