Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display Vault APY in pools table #282

Open
wants to merge 1 commit into
base: v2
Choose a base branch
from
Open

Conversation

PaulMcInnis
Copy link
Collaborator

Like it says on the box, now we have a sortable APY column in pools:

Note:

  • I think when we have many pools this might become a scalability issue (pulling vaults for every pool vs using pagination), so i’ve filed a tech debt issue for this.
  • Thinking maybe we wanna title the column in a way that its clear that this is vault APY? (Does this matter?)
  • Some pools dont currently have vaults, so I’m displaying a - character for those
  • Some APYs are pretty high on testnet rn, need to berify that this is testnet tokenomics and not an issue elsewhere. (If the pool has low liquidity should we show APY at all?)

@PaulMcInnis PaulMcInnis self-assigned this Dec 24, 2024
Copy link

vercel bot commented Dec 24, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 24, 2024 7:04pm
v2-honey ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 24, 2024 7:04pm
v2-hub ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 24, 2024 7:04pm
6 Skipped Deployments
Name Status Preview Comments Updated (UTC)
bartio-dex ⬜️ Ignored (Inspect) Dec 24, 2024 7:04pm
bartio-honey ⬜️ Ignored (Inspect) Dec 24, 2024 7:04pm
bartio-lend ⬜️ Ignored (Inspect) Dec 24, 2024 7:04pm
bartio-perps ⬜️ Ignored (Inspect) Dec 24, 2024 7:04pm
bartio-station ⬜️ Ignored (Inspect) Dec 24, 2024 7:04pm
berajs-docs ⬜️ Ignored (Inspect) Dec 24, 2024 7:04pm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant