Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: using computed properties to robots.ts #286

Open
wants to merge 1 commit into
base: v2
Choose a base branch
from

Conversation

MelodyFish
Copy link

@MelodyFish MelodyFish commented Dec 28, 2024

Current Situation

The robots.ts files in our apps contain redundant code structure with repeated object literals for handling allow/disallow rules.

Before:

if (isIPFS || process.env.DONT_INDEX === "1") {
    return {
      rules: {
        userAgent: "*",
        disallow: "/",
      },
    };
  }

  return {
    rules: {
      userAgent: "*",
      allow: "/",
    },
  };

After:

return {
    rules: {
      userAgent: "*",
      [isIPFS || process.env.DONT_INDEX === "1" ? "disallow" : "allow"]: "/",
    },
  };

Testing

  • Verified that robots.txt still generates correctly in development

Type of Change

  • Code refactoring (no functional changes)
  • Bug fix
  • New feature
  • Breaking change

it can resolved this issue

Copy link

vercel bot commented Dec 28, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
v2-honey ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 28, 2024 7:01am

Copy link

vercel bot commented Dec 28, 2024

Someone is attempting to deploy a commit to the Berachain Team on Vercel.

A member of the Team first needs to authorize it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant