Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bfe 178 ipfs fleek ci workflow #42

Merged
merged 63 commits into from
Sep 6, 2024
Merged

Conversation

bearpong
Copy link
Contributor

@bearpong bearpong commented Aug 30, 2024

This is on top of #30. Please merge that PR first.

this PR adds:

  • ci static build on pr to check it doesn't throw errors
  • fleek deploy when main branch is updated
  • .env.bartio file and pnpm setenv:bartio script
  • .env.artio even though a lot of variables are missing on artio. I think it should be declared as not supported anymore.

All domains under *.berachain.com have been whitelisted on Dynamic to solve cors issues.

Plese after merging this PR, all developers should:

  1. move secrets from .env to .env.local
  2. run pnpm setevn:bartio
  3. stop editing .env and keep .env.bartio updated
  4. Updated vercel build settings to use .env.bartio and keep only secrets on the vercel environment

@ninibear030
Copy link
Contributor

This is on top of #30. Please merge that PR first.

this PR adds:

  • ci static build on pr to check it doesn't throw errors
  • fleek deploy when main branch is updated
  • .env.bartio file and pnpm setenv:bartio script
  • .env.artio even though a lot of variables are missing on artio. I think it should be declared as not supported anymore.

In order to have this work properly, we should whitelist in Dynamic settings:

  • ipfs.bartio.bend.berachain.com
  • ipfs.bartio.berps.berachain.com
  • ipfs.bartio.bex.berachain.com
  • ipfs.bartio.honey.berachain.com
  • hub?

However, we can't whitelist all CID domains like XXXX.ipfs.dweb.link. We might use a wildcard, but all websites on IPFS might use our API key... need to find a solution to that.

Plese after merging this PR, all developers should:

  1. move secrets from .env to .env.local
  2. run pnpm setevn:bartio
  3. stop editing .env and keep .env.bartio updated
  4. Updated vercel build settings to use .env.bartio and keep only secrets on the vercel environment

should be these 4

  • ipfs.bartio.bend.berachain.com
  • ipfs.bartio.berps.berachain.com
  • ipfs.bartio.hub.berachain.com
  • ipfs.bartio.honey.berachain.com

{
"sites": [
{
"slug": "bartio-honey",
Copy link
Contributor

@ninibear030 ninibear030 Sep 5, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

v2 ^

{
"sites": [
{
"slug": "berps-bartio",
Copy link
Contributor

@ninibear030 ninibear030 Sep 5, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

v2-berps^

ninibear030 and others added 3 commits September 6, 2024 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants