Skip to content

Commit

Permalink
Disable media remoting by default
Browse files Browse the repository at this point in the history
Chromecast is crippled in upstream UC, so media
remoting can be safely disabled.

We can remove enable_media_remoting_rpc=false
from debian/rules, as this will automatically
become false when enable_media_remoting is set
to false.

There is an unmerged pull request which enables
chromecast [1], which I will implement in a
subsequent commit. However I will keep the media
remoting configuration option so that it can be
disabled independently of chromecast.

[1] ungoogled-software/ungoogled-chromium#2116
  • Loading branch information
berkley4 committed Mar 1, 2024
1 parent 78a14b9 commit 8de8325
Show file tree
Hide file tree
Showing 14 changed files with 17 additions and 17 deletions.
2 changes: 1 addition & 1 deletion configure-variables.txt
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ DRIVER 1 Chromedriver package
CLICK_TO_CALL 1 Feature for using chromium to make a call via an android phone
EXT_TOOLS_MENU 1 Move the extensions menu to the 'More tools' menu
FEED 1 WebFeed (News feed) support
MEDIA_REMOTING 1 Render and play back media on remote devices when a tab is casted
MEDIA_REMOTING 0 Render and play back media on remote devices when a tab is casted
MUTEX_PI 1 Mutex priority inheritance
NOTIFICATIONS 1 System notifications
OPENTYPE_SVG 1 Opentype SVG support
Expand Down
10 changes: 5 additions & 5 deletions debian/configure.sh
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ sanitise_op () {
[ -n "$DRIVER" ] || DRIVER=1
[ -n "$EXT_TOOLS_MENU" ] || EXT_TOOLS_MENU=1
[ -n "$FEED" ] || FEED=1
[ -n "$MEDIA_REMOTING" ] || MEDIA_REMOTING=1
[ -n "$MEDIA_REMOTING" ] || MEDIA_REMOTING=0
[ -n "$MUTEX_PI" ] || MUTEX_PI=1
[ -n "$NOTIFICATIONS" ] || NOTIFICATIONS=1
[ -n "$OAUTH2" ] || OAUTH2=0
Expand Down Expand Up @@ -610,11 +610,11 @@ if [ $FEED -eq 0 ]; then
fi


if [ $MEDIA_REMOTING -eq 0 ]; then
op_enable="$op_enable disable/media-remoting"
if [ $MEDIA_REMOTING -eq 1 ]; then
op_disable="$op_disable disable/media-remoting/"

#GN_FLAGS += enable_media_remoting=false enable_media_remoting_rpc=false
gn_enable="$gn_enable enable_media_remoting"
#GN_FLAGS += enable_media_remoting=false
gn_disable="$gn_disable enable_media_remoting"
fi


Expand Down
20 changes: 10 additions & 10 deletions debian/patches/series.debian
Original file line number Diff line number Diff line change
Expand Up @@ -52,15 +52,14 @@ vanadinite/0004-disable-article-suggestions-feature-by-default.patch
vanadinite/0005-disable-content-feed-suggestions-by-default.patch
vanadinite/0006-disable-sensors-access-by-default.patch
vanadinite/0007-disable-background-sync-by-default.patch
vanadinite/0008-disable-media-router-media-remoting-by-default.patch
vanadinite/0009-disable-media-router-by-default.patch
vanadinite/0010-disable-media-DRM-preprovisioning-by-default.patch
vanadinite/0011-enable-split-cache-by-default.patch
vanadinite/0012-enable-partitioning-connections-by-default.patch
vanadinite/0013-disable-component-updater-pings-by-default.patch
vanadinite/0014-Enable-strict-origin-isolation-by-default.patch
vanadinite/0015-enable-process-isolated-sandboxed-iframes-by-default.patch
vanadinite/0016-enable-partitioning-third-party-storage.patch
vanadinite/0008-disable-media-router-by-default.patch
vanadinite/0009-disable-media-DRM-preprovisioning-by-default.patch
vanadinite/0010-enable-split-cache-by-default.patch
vanadinite/0011-enable-partitioning-connections-by-default.patch
vanadinite/0012-disable-component-updater-pings-by-default.patch
vanadinite/0013-Enable-strict-origin-isolation-by-default.patch
vanadinite/0014-enable-process-isolated-sandboxed-iframes-by-default.patch
vanadinite/0015-enable-partitioning-third-party-storage.patch

various/compiler-flags/Do-not-link-with-libatomic.patch
various/compiler-flags/function-import-limits.patch
Expand Down Expand Up @@ -124,8 +123,9 @@ optional/cpu/avx.patch
#optional/disable/catapult.patch
#optional/disable/click-to-call.patch
optional/disable/dns_config_service.patch
#optional/disable/media-remoting.patch
optional/disable/supervised-users.patch
optional/disable/media-remoting/media-remoting.patch
optional/disable/media-remoting/registry-pref.patch
#optional/fixes/convertutf-bundled.patch
#optional/fixes/dav1d-bundled-header.patch
optional/fixes/extensions-in-tools-menu.patch
Expand Down
2 changes: 1 addition & 1 deletion debian/rules.in
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,7 @@ GN_FLAGS += \
#GN_FLAGS += enable_feed_v2=false

# Disable media remoting
#GN_FLAGS += enable_media_remoting=false enable_media_remoting_rpc=false
GN_FLAGS += enable_media_remoting=false

# Enable mutex priority inheritance
GN_FLAGS += enable_mutex_priority_inheritance=true
Expand Down

0 comments on commit 8de8325

Please sign in to comment.