Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translate multiple select drop down #3756

Draft
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

HThuren
Copy link
Member

@HThuren HThuren commented Jan 14, 2024

Use locale setup in multiple-select addon

#3583 will have same need for solution like this PR
BUT giving an "Uncaught TypeError: Cannot read properties of undefined (reading 'locales')"

Made an issue wenzhixin/multiple-select#618 to get help

NOT READY TO MERGE

This comment has been minimized.

@nerdCopter nerdCopter marked this pull request as draft January 16, 2024 16:25

This comment has been minimized.

@HThuren HThuren added the BUG label Jan 28, 2024

This comment has been minimized.

Copy link

sonarcloud bot commented Jan 29, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Contributor

Do you want to test this code? Here you have an automated build:
Betaflight-Configurator-Android
Betaflight-Configurator-Linux
Betaflight-Configurator-macOS
Betaflight-Configurator-Windows
WARNING: It may be unstable and result in corrupted configurations or data loss. Use only for testing!

@HThuren HThuren added this to the 11.0 milestone Feb 5, 2024
@ghiscoding
Copy link

@HThuren alternatively, you could take a look at an ms-select fork that I created mutiple-select-vanilla. The locales are working fine with imports. I created the fork mainly because I wanted to drop jQuery and also added a few more options. However this would require some code refactoring from your part, it might still be worth it though. Cheers

@HThuren
Copy link
Member Author

HThuren commented Feb 28, 2024

@HThuren alternatively, you could take a look at an ms-select fork that I created mutiple-select-vanilla. The locales are working fine with imports. I created the fork mainly because I wanted to drop jQuery and also added a few more options. However this would require some code refactoring from your part, it might still be worth it though. Cheers

@ghiscoding thank you, I'll will look into your solution :-)

Copy link

@RadAda81 RadAda81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A

@HThuren
Copy link
Member Author

HThuren commented Aug 19, 2024

A

Hi @RadAda81, not sure what your comment address ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants