bevy_core_pipeline: Apply #![deny(clippy::allow_attributes, clippy::allow_attributes_without_reason)]

[LikeLakers2]

Objective

• Deny the clippy::allow_attributes and clippy::allow_attributes_without_reason lints #17111

Solution

Set the clippy::allow_attributes and clippy::allow_attributes_without_reason lints to deny, and bring bevy_core_pipeline in line with the new restrictions.

No code changes have been made - except if a lint that was previously allow(...)'d could be removed via small code changes. For example, unused_variables can be handled by adding a _ to the beginning of a field's name.

Testing

cargo clippy and cargo test --package bevy_core_pipeline were run, and no errors were encountered.

[BenjaminBrienen]

I'll review after #16338 merged and this is updated to fix the conflict :)

[LikeLakers2]

I want to mention: I actually spent some time seeing if I could rewrite this loop to use an iterator (as the lint suggests to do).

However, I ultimately opted not to do so, as I found that I couldn't easily get i to be the same values without some very awkward-looking code.

I don't believe it's impossible to make an iterator work here though.

[Bleachfuel]

maybe

let iter  = lut_begin.ceil() as usize..=lut_end.floor() as usize

for i in iter {
}

seems a bit unnessecary tbh.

[LikeLakers2]

For what it's worth, that would silence the lint - but I suspect that that's a false negative with clippy. Hence, I don't think it would be a good idea compared to just silencing the lint as I have.

[Bleachfuel]

Those Impls seem double to me.

[Bleachfuel]

maybe

let iter  = lut_begin.ceil() as usize..=lut_end.floor() as usize

for i in iter {
}

seems a bit unnessecary tbh.

[LikeLakers2]

This PR is blocked on #16338 per Benjamin's request. Once that is merged, I will fix any conflicts and mark it as ready to merge.

[github-actions]

Your PR increases Bevy Minimum Supported Rust Version. Please update the rust-version field in the root Cargo.toml file.

[LikeLakers2]

No longer blocked by #16338 but I am personally blocking this on #17185