[Merged by Bors] - Bevy release train - add a workflow to manually create a PR updating Bevy version #3283
Conversation
mockersf
added
the
A-Build-System
|
yeah i think it is good to open the pr provisionally automatically at the start of the week, so that there is time for any needed manual checks/intervention, or finalizing stuff like release notes, before doing the actual release later in the week |
|
I did not test the cron and |
|
Very cool idea! My biggest question mark at this point is "should this be a cron job or a manually invoked workflow"? I'm down to try the cron job first and we can revisit if the timing ever feels weird. I do like that the cron job serves as a reminder that we need to cut a release soon. Keeps the train on track :) |
That was the goal 🚅 But I also left the |
|
Are you sure? I thought the set up is |
|
yup you're right, but the Monday part is not in the cron, it's in the action itself |
| --no-push \ | ||
| --exclude ci \ | ||
| --exclude errors \ | ||
| --exclude bevy-ios-example |
There was a problem hiding this comment.
Shouldn't we exclude crevice here, too? Currently, it gets bumped: https://github.com/mockersf/bevy/pull/62/files#diff-895f58564647a4ab76480d7ed11ff1679579391650cd98ea1329faa562abc85cL2
There was a problem hiding this comment.
I'm not sure how Cart will want to handle crevice: if vendored, it should be renamed to something like bevy_crevice, and the version could be changed to follow the rest of bevy, or we could freeze it to follow more closely upstream
There was a problem hiding this comment.
short term we will be vendoring crevice as bevy_crevice. Medium-to-long term, we'll either try to move back upstream, do a hard fork, or build our own thing.
There was a problem hiding this comment.
I agree that it makes sense to sync that version number with bevy
There was a problem hiding this comment.
This is no longer relevant, as bevy_crevice is no more.
alice-i-cecile
added
the
X-Controversial
|
@mockersf what's your current take on this having seen our first train release? Still useful? |
|
As the one cutting releases, I personally think automating the version number revving is a significant improvement. I think I'd prefer starting the release process to be a manual trigger instead of a cron job though to accommodate the "fuzziness" of the release train. Having a "release pr" pop up when we aren't ready for it, then having conflicts (or non-conflicting mismatched versions) get introduced after the fact seems undesirable. |
There was a problem hiding this comment.
@mockersf can you swap this to a manual trigger (or close it out)? I agree with Cart that the automated version bumping is great.
mockersf
force-pushed
the
bevy-release-train
branch
from
b317d4a to
46f08cc
Compare
alice-i-cecile
removed
the
X-Controversial
|
done, only left the manual trigger! |
alice-i-cecile
added
S-Ready-For-Final-Review
mockersf
changed the title
|
bors r+ |
…Bevy version (#3283) # Objective - Ensure future Bevy releases happens smoothly ## Solution - Add a workflow that will open a PR updating all Bevy crate that can be created manually example PR opened: mockersf#62 The day from this PR does not need to be the release day, it will just open the PR to prepare it. Later if we feel confident, it could push automatically to crates.io. how to trigger the workflow: https://docs.github.com/en/actions/managing-workflow-runs/manually-running-a-workflow
bors
bot
changed the title
…Bevy version (bevyengine#3283) # Objective - Ensure future Bevy releases happens smoothly ## Solution - Add a workflow that will open a PR updating all Bevy crate that can be created manually example PR opened: mockersf#62 The day from this PR does not need to be the release day, it will just open the PR to prepare it. Later if we feel confident, it could push automatically to crates.io. how to trigger the workflow: https://docs.github.com/en/actions/managing-workflow-runs/manually-running-a-workflow
…Bevy version (bevyengine#3283) # Objective - Ensure future Bevy releases happens smoothly ## Solution - Add a workflow that will open a PR updating all Bevy crate that can be created manually example PR opened: mockersf#62 The day from this PR does not need to be the release day, it will just open the PR to prepare it. Later if we feel confident, it could push automatically to crates.io. how to trigger the workflow: https://docs.github.com/en/actions/managing-workflow-runs/manually-running-a-workflow
Objective
Solution
example PR opened: mockersf#62
The day from this PR does not need to be the release day, it will just open the PR to prepare it. Later if we feel confident, it could push automatically to crates.io.
how to trigger the workflow: https://docs.github.com/en/actions/managing-workflow-runs/manually-running-a-workflow