refactor: create 1 decoder instance per package

This has no logic implications, but it feels like multiple instances are unnecessary
bevzzz · Feb 26, 2024 · 8371047 · 8371047
1 parent e207fd5
commit 8371047
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 9 deletions.
diff --git a/schema/v3/schema.go b/schema/v3/schema.go
@@ -19,9 +19,10 @@ import (
 )
 
 func init() {
-	decode.RegisterDecoder(schema.Version{Major: 3, Minor: 0}, new(decoder))
-	decode.RegisterDecoder(schema.Version{Major: 2, Minor: 0}, new(decoder))
-	decode.RegisterDecoder(schema.Version{Major: 1, Minor: 0}, new(decoder))
+	d := new(decoder)
+	decode.RegisterDecoder(schema.Version{Major: 3, Minor: 0}, d)
+	decode.RegisterDecoder(schema.Version{Major: 2, Minor: 0}, d)
+	decode.RegisterDecoder(schema.Version{Major: 1, Minor: 0}, d)
 }
 
 // decoder decodes cell contents and metadata for nbformat v3.0, v2.0, and v1.0.

diff --git a/schema/v4/schema.go b/schema/v4/schema.go
@@ -17,12 +17,13 @@ import (
 )
 
 func init() {
-	decode.RegisterDecoder(schema.Version{Major: 4, Minor: 5}, new(decoder))
-	decode.RegisterDecoder(schema.Version{Major: 4, Minor: 4}, new(decoder))
-	decode.RegisterDecoder(schema.Version{Major: 4, Minor: 3}, new(decoder))
-	decode.RegisterDecoder(schema.Version{Major: 4, Minor: 2}, new(decoder))
-	decode.RegisterDecoder(schema.Version{Major: 4, Minor: 1}, new(decoder))
-	decode.RegisterDecoder(schema.Version{Major: 4, Minor: 0}, new(decoder))
+	d := new(decoder)
+	decode.RegisterDecoder(schema.Version{Major: 4, Minor: 5}, d)
+	decode.RegisterDecoder(schema.Version{Major: 4, Minor: 4}, d)
+	decode.RegisterDecoder(schema.Version{Major: 4, Minor: 3}, d)
+	decode.RegisterDecoder(schema.Version{Major: 4, Minor: 2}, d)
+	decode.RegisterDecoder(schema.Version{Major: 4, Minor: 1}, d)
+	decode.RegisterDecoder(schema.Version{Major: 4, Minor: 0}, d)
 }
 
 // decoder decodes cell contents and metadata for nbformat v4.0.