Add docs and type annotations to unit_buildmenu_config.lua
#3936
+48
−47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhys-vdw
changed the title
rhys-vdw
changed the title
unit_buildmenu_config.lua
This was referenced Nov 14, 2024
saurtron
reviewed
Nov 15, 2024
saurtron
reviewed
Nov 15, 2024
|
couple things slipped from #3935 but rest looks fine! |
Right, it's in the description lol. Anyways it's not very good practice to base one PR on top of another since you never know which will be merged first and just generating confusion. |
Agreed! I was told PRs were reviewed merged on Thursday, and instead of being merged I just got this comment: |
|
@rhys-vdw Can you resolve merge conflicts, then this should be good to merge |
Doesn't seem to be serving a purpose and complicates type annotations (to be added in a later commit)
Add doc comments, types and minor styling cleanup.
rhys-vdw
force-pushed
the
rhys/grid-buildmenu-config-types
branch
from
003a286 to
7908a93
Compare
|
@rhys-vdw Why did you close this PR? |
|
Yes, but why? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work done
Important
Includes changes from #3935, please review and merge that PR first.
Adds lua language server docs and type annotations to
unit_buildmenu_config.lua.This PR replaces #3905 which was rejected for including code cleanup and documentation changes in one PR.
Test steps
No functional changes