-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make CI great again #308
Make CI great again #308
Conversation
Should probably wait for #304 to be merged since the different otp/elixir version seems to be causing some issues. |
I'm still getting 29 failures locally, 3 more than here in CI, when calling |
Yeah, this needs more work, I'll get to it at some point this week |
4d518db
to
e54eec8
Compare
riiiight, so this passes locally, but not in CI, that one isn't going to be fun |
Maybe even have multiple separate tags for those? Probably overkill and silly, but something to consider. |
73ffb76
to
a720ad0
Compare
Alright, I managed to reproduce the errors. |
Because that's where they should live. And also, because there are some reference to ExUnit in this file now, that is only available during tests. Putting the test_lib file under test makes dialyzer happier since it's on the correct compiler path.
c828de5
to
f0c3e08
Compare
f0c3e08
to
4c8239a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice looks like CI Tests all pass. Even though some tests have been disabled it at least makes CI useful again.
Alternative title: declare test bankruptcy.
This PR adds a tag to ignore all currently failing tests. The output of
mix test --exclude needs_attention
is still drowned in error logs, but at least all tests are passing. This is making the CI step useful, if a known good test starts to fail, people will notice.And then we can start having a look at slowly removing these tags and fixing the tests. There is really a mix bags: