Minor improvements to whoami and whois commands #333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jauggy
changed the title
geekingfrog
approved these changes
Jun 16, 2024
|
tbf, if the stats you get there are incorrect, that's probably a different problem, and probably a different PR. |
L-e-x-o-n
approved these changes
Jun 28, 2024
|
Added Chevron Level to $whoami based on @L-e-x-o-n feedback |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improvements
Add chevron level to
$whois Xcommand. The purpose of this is to help diagnose issues where teiserver and chobby have a different idea of someone's chev levelThere's a joke that BAR is a lobby simulator. So let's add lobby hours to
$whoamiand find out for sure if this is the caseTest Steps
Inside a lobby run
$whoami$whois <username>Probably best testing this on integration server with real users to see what is saved for lobby hours.