Bugfix: Allow hosts to rename lobbies with equal priority to players. #382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With the new "!rename" command added to the BarManager SPADS plugin, a host may attempt to rename its lobby at the request of a player. Furthermore, BarManager no longer automatically changes lobby names (instead, it only updates the lobby's Teaser). However, after the very first rename for a lobby (starting from initial creation), Teiserver currently forbids any further renames originating from the host. This PR removes that restriction, allowing "!rename" to function as expected.
|
Note that I forgot to include: This fixes #371 |
jauggy
approved these changes
Jul 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR should only be deployed after all SPADS instances are running the new code from beyond-all-reason/spads_config_bar#136 !
(Otherwise, any non-updated SPADS instances will regularly set the lobby name back to the default)
Background and summary:
With the new "!rename" command added to the BarManager SPADS plugin, a host may attempt to rename its lobby at the request of a player. Furthermore, BarManager no longer automatically changes lobby names (instead, it only updates the lobby's Teaser).
However, after the very first rename for a lobby (starting from initial creation), Teiserver currently forbids any further renames originating from the host. This PR removes that restriction, allowing "!rename" to function as expected.