Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Seed test db will all possible game types. #501

Merged
merged 5 commits into from
Oct 18, 2024
Merged

Seed test db will all possible game types. #501

merged 5 commits into from
Oct 18, 2024

Conversation

bigbluejay9
Copy link
Contributor

The spads controller 'ratings existing user' test was failing as it was referring to a game type that is known but not seeded in the test db.

@bigbluejay9
Seed test db will all possible game types.
8140adf 
The spads controller 'ratings existing user' test was failing as it was
referring to a game type that is known but not seeded in the test db.
@bigbluejay9
Fix default rating value
091768b
@bigbluejay9
Copy link
Contributor Author

bigbluejay9 commented Oct 6, 2024 •
edited
Loading

This PR needs more work.

@bigbluejay9
Copy link
Contributor Author

It seems like the only test that's failing is test/teiserver_web/live/battle_live_test.exs:21 which would be marked as needs_attention after #510 is merged.

So this PR is ready to be merged (after #510).

@L-e-x-o-n L-e-x-o-n merged commit d5591f1 into beyond-all-reason:master Oct 18, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bigbluejay9 @L-e-x-o-n