Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add replay page button on match overview page #502

Merged

Conversation

L-e-x-o-n
Copy link
Collaborator

No description provided.

@L-e-x-o-n L-e-x-o-n force-pushed the improvement/replay-btn branch from dca6134 to 44b34c5 Compare October 6, 2024 15:45
Copy link
Collaborator

@StanczakDominik StanczakDominik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aw hell yeah.

@L-e-x-o-n
Copy link
Collaborator Author

L-e-x-o-n commented Oct 7, 2024

This is still work in progress.
For this to work for older matches (currently the cleanup task removes data for older matches as part of the cleanup task) I plan to add a new column in teiserver_battle_matches table called game_id containing gameId from data.

@p2004a this might be of interest to you, potentially useful for https://github.com/beyond-all-reason/data-processing ?

(Jazcash already added a button linking to Teiserver on the replays page)

@L-e-x-o-n L-e-x-o-n force-pushed the improvement/replay-btn branch from 44b34c5 to 75fe90d Compare October 15, 2024 08:08
@L-e-x-o-n L-e-x-o-n force-pushed the improvement/replay-btn branch from 75fe90d to e46588f Compare October 15, 2024 09:40
@L-e-x-o-n L-e-x-o-n marked this pull request as ready for review October 15, 2024 09:40
@L-e-x-o-n L-e-x-o-n merged commit 6638535 into beyond-all-reason:master Oct 15, 2024
2 of 3 checks passed
@jauggy
Copy link
Member

jauggy commented Oct 16, 2024

@L-e-x-o-n if I am developing locally with an older database schema, do I need to run a command to update the schema?
Should I just run mix ecto.migrate ?

@L-e-x-o-n
Copy link
Collaborator Author

@L-e-x-o-n if I am developing locally with an older database schema, do I need to run a command to update the schema? Should I just run mix ecto.migrate ?

Yes

@L-e-x-o-n L-e-x-o-n deleted the improvement/replay-btn branch October 16, 2024 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants