Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #499
Problems
TEI_DOMAIN_NAME
isn't set in local dev, then thedomain_name
local in runtime.exs used the default of"beyondallreason.info"
.TEI_DOMAIN_NAME
was set, the manual string interpolation"https://#{domain_name}"
didn't give the correct urls if TLS/SSL wasn't enabled.Solution
TeiserverWeb.Endpoint.static_url()
static_url/0 docs to get the base url.domain_name
is set on the endpoint module withurl: [host: domain_name]
, the domain should work the exact same as before in test/prod.http:
vshttps:
config used.http:
is used for local dev:{ issuer: "http://localhost:4000/" ...
http:
andhttps:
are used, the https url will take precedence.{ issuer: "https://localhost:4040/" ...
{ issuer: "https://localhost:4040/" ...