Add win prediction to players tab #532
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@L-e-x-o-n when you have spare time, can you please put this on integration server? I just want to check I didn't break matches that are unrated. It works locally. |
Done, seems to be working. |
|
@L-e-x-o-n this is ready for merge. Have checked on staging too. Working fine on rated games and bot matches not crashing. The automated test that failed has nothing to do with this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The purpose of this feature is because often players ask, "Why did I gain little for winning but lost a lot when losing?". This is mostly governed by the win prediction. If you are predicted to win, you will gain less for winning. Unexpected results cause bigger changes. Also the OS library thinks new players are average so will expect a team with only new players to win versus a team with below average players.
Changes
The win prediction is now on the players tab for a match at the bottom. I'm not 100% sure on the code for win predict when teams are not equal two so that is excluded.
Also the rating on the players tab will be their pre-match rating, which will make the win prediction and balance make more sense.