Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature
After running
This will add a new num_matches column to the database and also populate it with values. Whenever a match is rated, the num_matches numer will increase by one, with the exception that if it is a rating override, the num_matches will stay the same.
Purpose
The num_matches column can be used in the future for many possible use cases:
1. We can change the rating to become
This idea has been approved by Marek: Source
This means that new players start at 0 and converge towards their skill over time. We won't have tons of people stuck at 0 due to negative ratings since there's no more subtraction as with Teifion's formula of
skill-uncertainty
. Having new players start at 0 also means we can create noob lobbies that are max rating 10 instead of max 20.We can keep leaderboard rating the same.
2. The balancer can classify noobs using num_matches
Generally players prefer new players to be spread evenly across teams. The balancer does this by classifying noobs as someone who has uncertainty > 6.65 and chev level < 4. Using a num_matches to classify noobs is more intuitive and future proof.
Note these are future ideas and are not included in the PR.