Implement default range for Range Picker #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
|
Hello @antony, curious is Beyonk still maintaining this repository? If so, I could help out with a few more PR's to address existing issues. Let me know! |
|
Hi Timothy,
Yes we are indeed :) PRs are welcome!
Thank you,
Antony
On Mon, 10 Apr 2023 at 04:24, Timothy Wheelock ***@***.***> wrote:
Hello @antony <https://github.com/antony>, curious is Beyonk still
maintaining this repository? If so, I could help out with a few more PR's
to address existing issues. Let me know!
—
Reply to this email directly, view it on GitHub
<#65 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABVORLDOSVBWDB2XEB4YZ3XAN4OPANCNFSM6AAAAAAWSFN7HE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
--
…________________________________
ꜽ . antony jones . http://www.enzy.org
|
|
Awesome, glad to hear it. From my searching this looks like one of the best datepickers out there right now for Svelte. As far as contributing, this PR is a start! |
|
Looks great. Thank you for this. I'll review and merge later today! |
antony
reviewed
Apr 10, 2023
antony
approved these changes
Apr 10, 2023
|
This is merged now, but docs fail, and I'm not sure why. I notice they are still on snowpack, so we probably should move this lib to SvelteKit. I won't have time immediately, but will get to it ASAP. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello.
Thanks for your work on this library, it is one of the best datepickers out there for Svelte right now. However, in my use, I ran into a significant issue where the default date range for range picker is hard-coded to 1 month, rather than being configurable.
This PR exposes the default range as input props, so that this can be configurable.
This also solves issue #43
Usage: