fix: Ignore iframes where access is blocked by CORS

Related #105 Prevents `Blocked a frame with origin ... from accessing a cross-origin frame.` errors
bfanger · Mar 12, 2023 · afe6fc8 · afe6fc8
1 parent 7131084
commit afe6fc8
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 4 deletions.
diff --git a/packages/pixi-panel/src/connect.ts b/packages/pixi-panel/src/connect.ts
@@ -18,8 +18,12 @@ function detect() {
     }
     if (win.frames) {
       for (let i = 0; i < win.frames.length; i += 1) {
-        if (win.frames[i][varname]) {
-          return true;
+        try {
+          if (win.frames[i][varname]) {
+            return true;
+          }
+        } catch (_) {
+          // access to iframe was denied
         }
       }
     }

diff --git a/packages/pixi-panel/src/pixi-devtools/pixiDevtools.ts b/packages/pixi-panel/src/pixi-devtools/pixiDevtools.ts
@@ -16,8 +16,12 @@ export default function pixiDevtools() {
     }
     if (win.frames) {
       for (let i = 0; i < win.frames.length; i += 1) {
-        if (win.frames[i][varname]) {
-          return win.frames[i][varname];
+        try {
+          if (win.frames[i][varname]) {
+            return win.frames[i][varname];
+          }
+        } catch (_) {
+          // access to iframe was denied
         }
       }
     }