Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve install features #392

Merged
merged 1 commit into from
May 24, 2024

Conversation

grisumbras
Copy link
Contributor

@grisumbras grisumbras commented May 20, 2024

Proposed changes

Improvements to install features.

  1. Consider options when constructing values for install directories.
  2. Evaluate explicitly-provided values for directories relative to PWD, not base directory.
  3. Change 2 requires a different implementation of staging-prefix handling.
  4. The returned value is always rooted, unless a relative value was requested and it is a subdirectory of the base value.

Types of changes

  • New feature (non-breaking change which adds functionality)

1. Consider options when constructing values for install directories.
2. Evaluate explicitly-provided values for directories relative to PWD,
   not base directory.
3. Change 2 requires a different implementation of staging-prefix
   handling.
@grafikrobot grafikrobot merged commit 7baf56d into bfgroup:main May 24, 2024
142 checks passed
@grisumbras grisumbras deleted the improve/install-features branch May 26, 2024 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants