Fix defaults, update build process and add CI #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adrien-berchet
force-pushed
the
defaults
branch
4 times, most recently
from
7e282d8
to
5c69429
Compare
adrien-berchet
force-pushed
the
defaults
branch
from
5c69429
to
0af52ca
Compare
|
Thank you, this is great! |
bgeron
approved these changes
Nov 29, 2024
|
I would make another release except I'm running into pypa/setuptools#4759 which is blocking the upload to PyPI. I'll wait until that is fixed. Feel free to poke me once it's fixed and I'll go through the ceremony again. |
|
Hi @bgeron ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The defaults can not be updated because they are included in the function definitions. This new way allows to change them dynamically.
I also updated the
setup.py,pyproject.tomlandtox.inifiles.@bgeron