Change this forks "Scanner" tag to something different #315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 0911477. urllib3 is needed to postprocess/parse/URL for sanitization and privacy purpose (bibanon#192)
We fix this by carefully redacting the IP address in the JSON fields known to contain it.
* Revert "Remove urllib3 dependency" This reverts commit 0911477. urllib3 is needed to postprocess/parse/URL for sanitization and privacy purpose (bibanon#192) * IA currently leaks the IP address of the submitter. This is bad. We fix this by carefully redacting the IP address in the JSON fields known to contain it. * added tests * flake8 linting
- Use latest urllib3 instead of that specific version
…oaded the way yt-dlp keep track of downloaded items. - Amend bibanon#19 by adding optional idempotency between runs: While concurrent-instances can still rely on a "clean" download directory (bibanon#19) a single upload node can use --use-upload-archive can avoid source files removal. Subsequent runs of `tubeup` will omit files already uploaded. - Fixes bibanon#23 (and part of bibanon#233) - NB: Ability for upload_ia() to return None, paves the way to fix bibanon#36 or bibanon#109
…dia files. If `tubeup` is passed the path of info.json files instead of URL, then it will parse them and, if `--output` was set correctly (same value as previous `yt-dlp`) then recover the basename of the local files associated with this video. If used intelligently, especially in conjunction with: --ignore-existing-item # needed, for now, to avoid the download-archive codepath --yt=--format=... # use the same download format --yt=--no-overwrites ... then existing files may be uploaded without having been re-downloaded/overwritten. Usage isn't foolproof. Use at your own risks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, you haven't enabled the ability to make issues so I'm doing this here.
Every time a item is uploaded to Archive.org the "Scanner" tag on the item lists the script name and version:
BinAnon is requesting you change this, you can make it "tubeup-drzraf" or whatever you want, but not our Scanner ID. Your fork divirges from ours in function significantly, specifically with open yt-dlp flags that allow for non-standard output and we don't want staff or future historians confusing the two.
Please change this ASAP.
Thanks.