GRN2-397: fix(httpclient): updates certificate authorities #2930
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
|
Thanks @faust64 the patch seems to be not only adequate, but the only resort right now. |
jfederico
changed the title
|
Can the similar fix be applied for 2.5.0? I can't seem to find httpclient in gems on my running image. |
|
2.5.0 fails for a different reason: OpenSSL is too old to handle multiple chains correctly this should fix it: |
wbonis
pushed a commit
to styliteag/greenlight
that referenced
this pull request
Dec 15, 2021
thifranc
pushed a commit
to thifranc/greenlight
that referenced
this pull request
Dec 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As reported here: nahi/httpclient#445
The httpclient gem comes with quite an old list of trusted certificate authorities.
As of today, we are seeing Greenlight failing to query some OIDC server, complaining about our LetsEncrypt certificate being invalid -- while a curl, from our Greenlight container, suggests there is no such issue with our certificate.
Thanks to @maxbes that figured it out.
Here's a patch that might help.
Obviously, it would be better to fix the httpclient library directly ( see nahi/httpclient#446 )
In doubt, I'm leaving this one too. Best case, httpclient would have been updated soon. Otherwise, we know of another way ...
Testing Steps
Nothing specific / no change in Ruby code. Just make sure the image starts.
Screenshots (if appropriate):
N/A