Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Rails 7.2, Ruby 3.3, Alpine 3.20 #5976

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

Ithanil
Copy link
Contributor

@Ithanil Ithanil commented Dec 12, 2024

Basically, this PR is blindsidenetworks/scalelite#1122 and blindsidenetworks/scalelite#1125 applied to Greenlight.

It also contains bumps of the Rails & Puma gems to the same level as in Scalelite. Furthermore, a number of other gems is updated to fix issues with the upgrade or address deprecations.

Finally, the amazonlinux build is changed to allow for Ruby 3.3, similar to blindsidenetworks/scalelite#1132. Had to restrict react-hook-forms to <7.52 because NodeJS 16 is the highest buildable version AL2 (due to glibc dependency). Like for Scalelite, a move to AL2023 is necessary to allow long-term maintainability.

Testing

  • RSpecs pass
  • Regular Dockerfile build tested in deployment (not exhaustively tested)

More testing welcome, especially of the amazonlinux build!

@Ithanil Ithanil changed the title Update to Rails 7.2, Ruby 3.3, Alpine 3.20 Upgrade to Rails 7.2, Ruby 3.3, Alpine 3.20 Dec 12, 2024
@Ithanil Ithanil force-pushed the rails-72 branch 7 times, most recently from 229c1b6 to 74c53b2 Compare December 13, 2024 09:54
@Ithanil Ithanil force-pushed the rails-72 branch 2 times, most recently from 9f889a9 to 70d70d1 Compare December 13, 2024 11:09
@Ithanil Ithanil force-pushed the rails-72 branch 5 times, most recently from c3505aa to d1967ea Compare December 13, 2024 14:31
@Ithanil Ithanil force-pushed the rails-72 branch 2 times, most recently from 1fb4340 to 5ed7110 Compare December 13, 2024 15:10
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
3.5% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

@Ithanil Ithanil marked this pull request as ready for review December 13, 2024 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant