Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core): UX improvements for account pages #1617

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
+12 −14
Open

fix(core): UX improvements for account pages #1617

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bee0653
fix(core): UX improvements for account pages
bc-yevhenii-buliuk Nov 11, 2024
327011c
Merge branch 'main' into improve-account-ux
bc-yevhenii-buliuk Nov 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/slimy-months-hunt.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@bigcommerce/catalyst-core": patch
---

UX improvements for account pages
5 changes: 1 addition & 4 deletions core/app/[locale]/(default)/account/(tabs)/layout.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { getTranslations, setRequestLocale } from 'next-intl/server';
import { setRequestLocale } from 'next-intl/server';
import { PropsWithChildren } from 'react';

import { LocaleType } from '~/i18n/routing';
Expand All @@ -14,11 +14,8 @@ export default async function AccountTabLayout({ children, params }: Props) {

setRequestLocale(locale);

const t = await getTranslations('Account.Home');

return (
<>
<h1 className="my-8 text-4xl font-black lg:my-8 lg:text-5xl">{t('heading')}</h1>
<TabNavigation />
{children}
</>
Expand Down
8 changes: 3 additions & 5 deletions core/app/[locale]/(default)/account/(tabs)/settings/change-password/page.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,12 +24,10 @@ export default async function ChangePassword({ params }: Props) {
setRequestLocale(locale);

return (
<>
<div className="mx-auto lg:w-2/3">
<TabHeading heading="settings" />
<div className="mx-auto lg:w-2/3">
<ChangePasswordForm />
</div>
</>
<ChangePasswordForm />
</div>
);
}

Expand Down
8 changes: 3 additions & 5 deletions core/app/[locale]/(default)/account/(tabs)/settings/page.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,12 +24,10 @@ export default async function Settings() {
}

return (
<>
<div className="mx-auto lg:w-2/3">
<TabHeading heading="settings" />
<div className="mx-auto lg:w-2/3">
<UpdateSettingsForm {...customerSettings} />
</div>
</>
<UpdateSettingsForm {...customerSettings} />
</div>
);
}

Expand Down
Loading