Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: move margins to button in slideshow #1645

Merged
merged 1 commit into from
Nov 15, 2024

Conversation

andrewreifman
Copy link
Contributor

What/Why?

In the Slideshow component, if a slide description is removed, there was no spacing between the title and button. Margin classes were changed to ensure the title, description, and button had the proper spacing between them at all times.

Testing

View the Slideshow component and hide any slide description.

@andrewreifman andrewreifman requested a review from a team as a code owner November 15, 2024 18:39
Copy link

vercel bot commented Nov 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
catalyst-latest ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 15, 2024 6:45pm
5 Skipped Deployments
Name Status Preview Comments Updated (UTC)
catalyst ⬜️ Ignored (Inspect) Nov 15, 2024 6:45pm
catalyst-au ⬜️ Ignored (Inspect) Nov 15, 2024 6:45pm
catalyst-soul ⬜️ Ignored (Inspect) Nov 15, 2024 6:45pm
catalyst-uk ⬜️ Ignored (Inspect) Nov 15, 2024 6:45pm
catalyst-unstable ⬜️ Ignored (Inspect) Nov 15, 2024 6:45pm

Copy link

changeset-bot bot commented Nov 15, 2024

⚠️ No Changeset found

Latest commit: 6e76a05

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@jorgemoya jorgemoya added this pull request to the merge queue Nov 15, 2024
Merged via the queue into vibes/soul-with-makeswift with commit defe9ab Nov 15, 2024
9 checks passed
@jorgemoya jorgemoya deleted the andrew/slideshow-margin branch November 15, 2024 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants