Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Andrew/button transition #1657

Merged
merged 2 commits into from
Nov 19, 2024

Conversation

andrewreifman
Copy link
Contributor

What/Why?

The Button and ButtonLink components both included duration and easing classes on their parent containers. This is causing unexpected transition animations when changing the properties of these components within Makeswift.

Testing

Edit the margin or variant of the components within the Makeswift builder.

@andrewreifman andrewreifman requested a review from a team as a code owner November 18, 2024 22:04
Copy link

changeset-bot bot commented Nov 18, 2024

⚠️ No Changeset found

Latest commit: 3ff264b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Nov 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
catalyst-latest ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 18, 2024 11:25pm
5 Skipped Deployments
Name Status Preview Comments Updated (UTC)
catalyst ⬜️ Ignored (Inspect) Nov 18, 2024 11:25pm
catalyst-au ⬜️ Ignored (Inspect) Visit Preview Nov 18, 2024 11:25pm
catalyst-soul ⬜️ Ignored (Inspect) Visit Preview Nov 18, 2024 11:25pm
catalyst-uk ⬜️ Ignored (Inspect) Visit Preview Nov 18, 2024 11:25pm
catalyst-unstable ⬜️ Ignored (Inspect) Visit Preview Nov 18, 2024 11:25pm

@bookernath bookernath added this pull request to the merge queue Nov 19, 2024
Merged via the queue into vibes/soul-with-makeswift with commit f653669 Nov 19, 2024
9 checks passed
@bookernath bookernath deleted the andrew/button-transition branch November 19, 2024 03:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants