Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(core): use next canary and enable ppr #1658

Merged
merged 2 commits into from
Nov 19, 2024

Conversation

jorgemoya
Copy link
Contributor

@jorgemoya jorgemoya commented Nov 18, 2024

What/Why?

  • Bumps next to canary
  • Enables PPR
  • Use new expirePath/expireTag functions.

We will need PPR in Header to properly render cart count.

Testing

Locally PPR is enabled in static sites.

@jorgemoya jorgemoya requested a review from a team as a code owner November 18, 2024 22:08
Copy link

changeset-bot bot commented Nov 18, 2024

⚠️ No Changeset found

Latest commit: 8ff39ce

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Nov 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
catalyst-latest ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 18, 2024 10:29pm
5 Skipped Deployments
Name Status Preview Comments Updated (UTC)
catalyst ⬜️ Ignored (Inspect) Nov 18, 2024 10:29pm
catalyst-au ⬜️ Ignored (Inspect) Visit Preview Nov 18, 2024 10:29pm
catalyst-soul ⬜️ Ignored (Inspect) Visit Preview Nov 18, 2024 10:29pm
catalyst-uk ⬜️ Ignored (Inspect) Visit Preview Nov 18, 2024 10:29pm
catalyst-unstable ⬜️ Ignored (Inspect) Visit Preview Nov 18, 2024 10:29pm

Copy link
Contributor

⚡️🏠 Lighthouse report

Lighthouse ran against https://catalyst-latest-dxfkrpa6l-bigcommerce-platform.vercel.app

🖥️ Desktop

We ran Lighthouse against the changes on a desktop and produced this report. Here's the summary:

Category Score
🟠 Performance 78
🟢 Accessibility 96
🟢 Best practices 100
🟠 SEO 82

📱 Mobile

We ran Lighthouse against the changes on a mobile and produced this report. Here's the summary:

Category Score
🟠 Performance 85
🟢 Accessibility 96
🟢 Best practices 100
🟠 SEO 85

@jorgemoya jorgemoya merged commit d693ac4 into soul/main Nov 19, 2024
11 of 12 checks passed
@jorgemoya jorgemoya deleted the soul/main-ppr-in-header branch November 19, 2024 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants