Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix command check for Windows in create #1683

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

benbhall
Copy link

Closes #1463

What/Why?

Fix the create CLI command to improve cross-platform compatibility when checking for required tools (git and pnpm). Currently it does not work on Windows.

  • Introduced a utility function getPlatformCheckCommand
  • Using where.exe (instead of where) for Windows to avoid conflicts with PowerShell's Where-Object.
  • Fall back to existing which for Unix systems.

Testing

  • Simulated missing tools to confirm that error messages display as expected.
  • Windows: Tested in Command Prompt and PowerShell, with and without git/pnpm available.

No specific regression testing done over Linux/MacOS behaviour.

@benbhall benbhall requested a review from a team as a code owner November 23, 2024 13:34
Copy link

changeset-bot bot commented Nov 23, 2024

⚠️ No Changeset found

Latest commit: c8508e6

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Nov 23, 2024

Someone is attempting to deploy a commit to the BigCommerce Platform Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

vercel bot commented Nov 23, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
catalyst-uk ⬜️ Ignored (Inspect) Visit Preview Nov 23, 2024 7:38pm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

create-catalyst @0.13.0 failing to start in Windows 10 - GIT not found error
1 participant