Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add annotation count feature #658

Merged
merged 4 commits into from
Sep 28, 2023
Merged

Add annotation count feature #658

merged 4 commits into from
Sep 28, 2023

Conversation

lehecht
Copy link
Contributor

@lehecht lehecht commented Sep 22, 2023

Display an annotation count in the annotations tab beneath the filter. If a filter is active, return an filtered annotation count and total annotation count.

Resolves #459

Display an annotation count in the annotations tab
beneath the filter. If a filter is active, return an
filtered annotation count and total annotation count.

Resolves #459
Copy link
Member

@mzur mzur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! What do you think about a style like this?

image

This matches the badge counts below. We only need to make sure the users understand what the count means, so I added "Total". The text uses the text-muted class so it can be distinguished from the label names.

I also thought about putting the total count at the bttom of the list which could be more intuitive. But this would hide the count if the list gets too long.

If the filtering is active, the badge could still show "yy/xx".

resources/assets/js/annotations/annotatorContainer.vue Outdated Show resolved Hide resolved
resources/assets/js/videos/videoContainer.vue Outdated Show resolved Hide resolved
Merge computed props and return string depending on active filters.
@mzur

This comment was marked as outdated.

Copy link
Member

@mzur mzur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thanks!

@mzur mzur merged commit 8ec8322 into master Sep 28, 2023
@mzur mzur deleted the annotation-count-feature branch September 28, 2023 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show complete count of annotations
2 participants