-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create volume flow v2 #709
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Here are the tests that an iFDOv2 metadata parser should fulfill: core/tests/php/Traits/ParsesMetadataTest.php Lines 102 to 488 in 91ac92b
|
When the metadata file is uploaded it is not clear which files the volume will have with the create volume v2 flow. Instead, metadata of files not in the volume will be ignored. Also, files without metadata will simply be not populated.
The annotation/file label import is still missing.
The user is first redirected to the pending volume view and from there to the subsequent steps if relevant.
This was referenced Apr 18, 2024
Open
This was
linked to
issues
Apr 19, 2024
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #701
Plan:
file extensionsMIME types for validation of the form request as well as theaccept
attribute of the HTML input elements.ParsesMetadata
trait. Update everything with "metadata" or "Ifdo" in it.metadata_parser
column for volumes that specifies which metadata parser class should be used for the metadata fileand label tree UUIDsfor each label (for matching during import) and the label colorExport the non-standard user UUID for each annotator (for matching during import)already done with theid
property.Linked PRs
Upgrade instructions
VOLUME_METADATA_STORAGE_DISK
andVOLUME_PENDING_METADATA_STORAGE_DISK
(with config)