-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement video sprite generator #712
Conversation
the function generateSprites generates sprites from a video file, organizes them into a 5x5 sprite sheet, and saves them.
I have changed the target branch in biigle/core so we can merge the backend code in this pull request and then merge the frontend code in a second pull request. If the code of this pull request is ready for review, please click "request review" (from me) here at the top right of the pull request. I'll have a look at the code and add comments then. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! There is only a variable naming issue and the reusable function that I didn't explain clearly enough before 😉 I hope now it's more clear, otherwise please ask.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks 👍
Add the function generateSprites which generates sprites from a video file, organizes them into a
5x5 sprite sheets. Related to #375