Replace assertEquals by assertSame #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mzur
requested changes
Aug 21, 2024
mzur
reviewed
Aug 22, 2024
There was a problem hiding this comment.
I see. So this was a little careless of me. The numbers are strings because they can get too large for an int right? Then they should of course remain strings... sorry.
If you see some comment like this from me again, feel free to argue against it if you think it is stupid 😉
I thought you knew it and still wanted it to be changed which is why I did it. Next time I'll ask. |
This reverts commit f8593a3.
mzur
approved these changes
Aug 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use assertSame for strong equality check,
References biigle/core#430.