Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add flat label list tab #194

Open
wants to merge 67 commits into
base: master
Choose a base branch
from
Open

Add flat label list tab #194

wants to merge 67 commits into from

Conversation

lehecht
Copy link
Contributor

@lehecht lehecht commented Nov 12, 2024

  • Add tests in VideoAnnotationControllerTest
  • Add tests in ImageAnnotationControllerTest
  • Add project largo flat tab view
  • Update annotation count after swapping/deleting labels
  • Update label highlighting in LabelTab (and vice versa)

Closes #170.

@lehecht lehecht marked this pull request as ready for review December 4, 2024 08:29
@lehecht lehecht requested a review from mzur December 4, 2024 08:30
Copy link
Member

@mzur mzur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really nice! Here come the high-level comments:

  • If I read the code right, you populate the tab based on a list of all annotations in the project/volume? This is far too inefficient. Instead, the API should return a list of labels only (and their number of annotations), i.e. exactly what the tab should show. You should be able to get this list with a single DB query, too. Then there also should be no need for a streamed response.

  • The labels should be ordered alphabetically (like with the trees).

  • The new tab should be the second from the top.

  • The new tab title should be "label list".

  • There is an issue with the spacing of selected labels:

    Screencast.from.06.12.2024.11.58.27.webm

@lehecht
Copy link
Contributor Author

lehecht commented Dec 13, 2024

@mzur

  • the API should return a list of labels only (and their number of annotations)

If I return only the labels, it is not possible any more to use them later for the labels tree tab, because it needs the image's uuid and annotation id.

@mzur
Copy link
Member

mzur commented Dec 18, 2024

But the labels for the label trees tab already come from biigle.$require('largo.labelTrees'), right? The new API endpoint is only there for the new flat labels tab so the endpoint can only return the information required for this tab, too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flat label list tab
2 participants