-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add flat label list tab #194
base: master
Are you sure you want to change the base?
Conversation
This reverts commit 2f61053.
Remove annotation list
Lower memory usage by joining tables instead of looping through collections.
Labels are already saved in labeltrees in largoContainer.
If label is new, add label to annotations tab.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks really nice! Here come the high-level comments:
-
If I read the code right, you populate the tab based on a list of all annotations in the project/volume? This is far too inefficient. Instead, the API should return a list of labels only (and their number of annotations), i.e. exactly what the tab should show. You should be able to get this list with a single DB query, too. Then there also should be no need for a streamed response.
-
The labels should be ordered alphabetically (like with the trees).
-
The new tab should be the second from the top.
-
The new tab title should be "label list".
-
There is an issue with the spacing of selected labels:
Screencast.from.06.12.2024.11.58.27.webm
If I return only the labels, it is not possible any more to use them later for the labels tree tab, because it needs the image's uuid and annotation id. |
But the labels for the label trees tab already come from |
Closes #170.