Make ApplyLargoSession job more robust against errors #198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a job failed for some other reason than an exception during saving, the largo_job_id was not cleaned up and no error was shown. This is handled more robustly now. Also we need a mechanism to prevent re-running of the failed job. Otherwise unexpected changes could be applied. The exprected behavior is now that the user is shown the error message and they try to save the session again. The old job should be discarded then.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a job failed for some other reason than an exception during saving, the largo_job_id was not cleaned up and no error was shown. This is handled more robustly now. Also we need a mechanism to prevent re-running of the failed job. Otherwise unexpected changes could be applied. The exprected behavior is now that the user is shown the error message and they try to save the session again. The old job should be discarded then.