Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate with Vala sdk extension #124

Merged
merged 1 commit into from
Mar 2, 2022
Merged

Conversation

bilelmoussaoui
Copy link
Owner

@bilelmoussaoui bilelmoussaoui commented Mar 2, 2022

Part of #75

@bilelmoussaoui
Copy link
Owner Author

I am waiting for the SDK to be published on flathub first, then give it a try with some Vala app

@SeaDve
Copy link
Collaborator

SeaDve commented Mar 2, 2022

'vala', 'rust' etc. I guess should be its own type (e.g. type LanguageCode = 'vala' | 'rust')

@bilelmoussaoui
Copy link
Owner Author

'vala', 'rust' etc. I guess should be its own type (e.g. type LanguageCode = 'vala' | 'rust')

Right, ideally we would do the whole integration as an interface that gets implemented by the various integrations and we have some class that fetches all those integrations and enables them based on the SDK Type or something like that.

But that is more of a task I would keep for later then do as part of this merge request

@bilelmoussaoui
Copy link
Owner Author

I tried it locally and it seems to at least be running properly, the main issue is vls seems to be having issues to properly start vala-lang/vala-language-server#236 but that is unrelated to this.

@bilelmoussaoui bilelmoussaoui merged commit 501ec18 into master Mar 2, 2022
@bilelmoussaoui bilelmoussaoui deleted the bilelmoussaoui/vala branch March 2, 2022 10:16
@SeaDve SeaDve mentioned this pull request Mar 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants