manifest: Allow to configure directories to ignore while searching for manifests #239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows to manipulate the manifest map without changes to the filesystem.
bilelmoussaoui
approved these changes
Aug 18, 2024
|
Thank you! |
|
I'm sorry I didn't have the chance to review it. I somehow didn't get a notification, or at least missed it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using other build systems in the same directory, it is possible that the extension does not find manifests because it gets the first 1000 YAML and JSON files it encounters and none of them are manifests, resulting in the same problem as #229. A solution for that is to be able to configure which directories to ignore, so it is more likely that it will be able to get the manifests in the result.
The first commit is preparatory work for the second commit, to allow us to refresh the map of manifests when the config changes, thus avoiding to have to reload the extension to take those changes into account.
Tested locally.