-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Try to fix skipping build of immuneml 3.0.3 #52702
Merged
martin-g
merged 14 commits into
bioconda:master
from
pavelvazquez:build-fix-immuneml-3.0.3
Dec 12, 2024
Merged
Try to fix skipping build of immuneml 3.0.3 #52702
martin-g
merged 14 commits into
bioconda:master
from
pavelvazquez:build-fix-immuneml-3.0.3
Dec 12, 2024
+3
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hi @martin-g You reviewed our update PR recently. Would you mind taking a look at this one when you have the time? Thank you! |
martin-g
reviewed
Dec 11, 2024
Co-authored-by: Martin Grigorov <[email protected]>
pavelvazquez
commented
Dec 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The build failed. Seems for new versions of a package, the build
number must start at 0
as no previous build exists for this version?
martin-g
approved these changes
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous PR of immuneml 3.0.3 (#52510) skipped building the package, causing errors in the Upload workflows, as no artifacts were present.
Possibly due to incorrect formatting of
skip
line.