Tremor weekly aggregation #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tremor_weekly_aggregation
Erikpostt
reviewed
Dec 23, 2024
There was a problem hiding this comment.
Execution counts in the notebook.
Erikpostt
reviewed
Dec 23, 2024
| nr_windows_daytime = df_filtered.shape[0] # number of windows during daytime on valid days | ||
| df_filtered = df_filtered.loc[df_filtered.low_freq_power <= config.movement_threshold] | ||
| nr_windows_daytime_rest = df_filtered.shape[0] # number of windows during daytime on valid days without non-tremor arm movement | ||
| # remove windows with detected non-tremor movements |
There was a problem hiding this comment.
Perhaps you could specify that above the movement threshold, you expect there to be movement that interferes(?) with the tremor quantification. I'm not sure about the specifics, but it might make sense to clarify this subsetting.
Erikpostt
reviewed
Dec 23, 2024
| "nr_valid_days": 1, | ||
| "nr_windows_daytime": 182, | ||
| "nr_windows_daytime_rest": 89 | ||
| "nr_windows_rest": 89 | ||
| }, | ||
| "weekly_tremor_measures": { | ||
| "tremor_time": 16.853932584269664, |
There was a problem hiding this comment.
Perhaps you could specify the units here.
Erikpostt
approved these changes
Dec 23, 2024
There was a problem hiding this comment.
Looking good! I made a few suggestions to change, feel free to make these changes if you agree, and then you can merge it yourself.
@nienketimmermans back to you.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I modified the aggregation step so that the daytime hours and valid days are not taken into account.