Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add start and end properties to TSDFMetadata #88

Merged
merged 1 commit into from
Dec 5, 2024
Merged

Conversation

twanvl
Copy link
Contributor

@twanvl twanvl commented Oct 22, 2024

Add start and end properties to TSDFMetadata, that return the start/end of a recording as a datetime. There are already getters and setters for these property. This pr just wraps them in a property.

…rt/end of a recording as a datetime. There were already getters and setters. This just wraps them in a @Property.
@Erikpostt Erikpostt self-requested a review December 5, 2024 10:25
Copy link
Contributor

@Erikpostt Erikpostt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm new to the property function in Python, so I'll have to take some more time to get the hang of it. Perhaps we could discuss this sometime?

Merging now.

@Erikpostt Erikpostt merged commit 368b7ae into main Dec 5, 2024
1 check passed
@Erikpostt Erikpostt deleted the datetime-properties branch December 5, 2024 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants