-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement #87: TSDFRecording based API #90
base: main
Are you sure you want to change the base?
Conversation
The new functions should probably also be exported from |
This also warrants an increase in the package version number. |
Hey @twanvl, overall this looks very neat -- I'd like to merge this soon. I do have a few questions:
Let me know what you think. We could also merge your suggestions, and add issues related to my questions if you think they are valid. |
|
@twanvl you want me to implement these suggestions to your PR? |
I have fixed all the issues mentioned above. I also added an I also added tests to ensure that all non-standard metadata is preserved when reading/writing. |
This PR implements a more convenient interface for working with single-recording tsdf files.
See #87 for a detailed description and motivation.
The most basic use case now becomes: