Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API Improvements #8

Merged
merged 9 commits into from
Nov 14, 2022
Merged

API Improvements #8

merged 9 commits into from
Nov 14, 2022

Conversation

cthoyt
Copy link
Member

@cthoyt cthoyt commented Nov 14, 2022

This PR has multiple useful additions including:

  1. Auto-merge of ontologies
  2. Loading local OBO Graph JSON
  3. Performance improvements when loading bioregistry converter (related to Performance: Loading from robot modules taking ~24 seconds #7)
  4. Better normalization of properties and access to them
  5. Simpler interface for getting version after parsing

Blocked by

@codecov-commenter
Copy link

Codecov Report

Base: 38.04% // Head: 35.22% // Decreases project coverage by -2.81% ⚠️

Coverage data is based on head (57bf12b) compared to base (ee28000).
Patch coverage: 25.80% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main       #8      +/-   ##
==========================================
- Coverage   38.04%   35.22%   -2.82%     
==========================================
  Files          10       10              
  Lines         665      687      +22     
  Branches      127      132       +5     
==========================================
- Hits          253      242      -11     
- Misses        400      432      +32     
- Partials       12       13       +1     
Impacted Files Coverage Δ
src/bioontologies/robot.py 41.21% <21.05%> (-3.40%) ⬇️
src/bioontologies/obograph.py 44.13% <27.27%> (-0.79%) ⬇️
src/bioontologies/__init__.py 100.00% <100.00%> (ø)
src/bioontologies/upgrade/__init__.py 0.00% <0.00%> (-40.63%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@cthoyt cthoyt merged commit d7c8cef into main Nov 14, 2022
@cthoyt cthoyt deleted the mira-updates branch November 14, 2022 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants