Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add biothings suppkg to config #724

Closed
wants to merge 1 commit into from
Closed

feat: add biothings suppkg to config #724

wants to merge 1 commit into from

Conversation

colleenXu
Copy link
Collaborator

@colleenXu colleenXu commented Sep 12, 2023

will allow use by team-specific endpoints and ara
related to #706

@colleenXu colleenXu requested a review from tokebe September 12, 2023 06:41
@colleenXu
Copy link
Collaborator Author

colleenXu commented Sep 12, 2023

@tokebe

We may want to pause on deploying this, for reasons besides the code-freeze on test/prod

  • if we wanted to avoid TRAPI-validator errors / allow the UI to handle these infores, we'd want Translator's infores catalog to be updated with the infores IDs used AND for downstream resources to use this updated infores catalog (UI? are there other downstream Translator resources? reasoner-validator / ARAX UI?)
  • I'd like to wait for a reply from Yao and Andrew on my post

@colleenXu colleenXu changed the title feat: add suppkg to config feat: add biothings suppkg to config Sep 12, 2023
@colleenXu
Copy link
Collaborator Author

@tokebe

There's one more issue to resolve, then this is ready to deploy:

  • whether the UI is using a "version" of the infores registry w/ suppKG info (see my Translator Slack post asking about this) - this is so the UI can display provenance information properly for edges from this KP

The "UMLS:DC" IDs issue has been resolved for now, since I discussed things with Andrew after his latest reply

@colleenXu colleenXu added the On Dev Related changes are deployed to Dev server label Oct 20, 2023
@colleenXu
Copy link
Collaborator Author

colleenXu commented Oct 20, 2023

Belated update: the issue above has been resolved. So we can move ahead with deployment

The infores registry changes for suppKG and TTD are here. UI team said yesterday (Translator Slack link)

the UI ingested the infores catalog 3 weeks ago and I verified it includes the changes you posted above

@tokebe
Copy link
Member

tokebe commented Oct 24, 2023

Superseded by biothings/bte-server@58177d3

Future changes to the api list will happen in https://github.com/biothings/bte-server

@tokebe tokebe closed this Oct 24, 2023
@tokebe tokebe deleted the add-suppkg branch October 25, 2023 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
On Dev Related changes are deployed to Dev server
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants