Clone records recursively before caching #27
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(fixes biothings/biothings_explorer#234)
This change replaces current
cache_handler._copyRecord
behavior to recursively clone each record, 'freezing' values from getters into standard data properties (also recursively -- if a getter returns an object, that object is recursively cloned).Unlike #25, this change is slightly more future-proof in that no values to be saved are hard-coded. This may result in some bloating of the data being cached, however.
The following example query returns kg_nodes with
biolink:undefined
categories, but should work as expected with this change.