-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Data source: repoDB #77
Comments
This CSV Drugbank Vocabulary seems to be open source and contains drugbank id to name data. It also contains names for some of the IDs you were not able to find in mychem (ie. DB12430). |
Thank you @rjawesome for the information! That CSV would definitely help! |
I can also make a PR for this on the parser if you want... |
Sure, @rjawesome, I appreciate your help! |
See this pr |
Thank you, @rjawesome! Yep I realized that injective relation is enough for "one-to-one"... |
Don't know if this needs SmartAPI annotation... |
Hi @colleenXu, this is a bug fix to the old repoDB API. It should have been annotated before. |
If it does, it's likely very old. It's not incorporated into BTE at the moment. |
Let's use this as an opportunity to add a SmartAPI annotation for BTE integration. I'm going to reopen the ticket, unassign @erikyao and @rjawesome, and add it to the "Needs SmartAPI / BTE annotation" section of our project tracker... |
example record https://biothings.ncats.io/repodb/chemical/DB14707 :
|
Related infores stuff is ready:
|
Here's the SmartAPI yaml w/ x-bte annotation for BioThings repoDB. This yaml is registered in SmartAPI Registry. I haven't made a PR to add this to BTE's regular use (for the config file, Example query
send a POST request to the api-specific endpoint, BioThings repoDB only. Like Put this in the request body: It's querying with the drug Cetuximab (aka
You should get a response with this edge (from this record in the BioThings API, based on this operation's example:
|
However, I have some observations / possible next steps:
"NA" is a common value for these fields
Mockup of what association-centric data may look like
Right now, there's 1 record for the drug Rituximab. It'd be transformed into multiple records, 1 for each combo of rituximab + unique disease + unique status. So for rituximab + "Lymphoma, Non-Hodgkin"
Problem 1: When I query with a disease ID and a specific indication status, I can't retrieve only the hits where both constraints are true in the same nested object.
Related to biothings/biothings_explorer#727 (comment) For example, I can try querying for the indication
I'll get hits like this in the response, which show that the indication matched but the status didn't. At the moment, we don't have BTE post-processing to recognize and remove hits like this: BTE will use them for answer edges even though they didn't actually match what I wanted.
Problem 2: When I query with a disease ID, I don't get back info for only that disease ID. So I have to exclude useful info like the disease-name field from the response-mapping
Related to biothings/biothings_explorer#316 (comment) I can take the
And then test the operation with a local BTE override and a disease ID that SRI NodeNorm doesn't recognize (C0334634,
In the response repodbC0334634.txt, BTE has given that ID the wrong label "Precocious Puberty"...probably because the subquery's first hit has
|
After discussion with Andrew yesterday, I've opened an issue for the next steps. However, it should be fine if these next steps aren't done by the time we add this API to BTE's regular use - we can still go forward with deploying. |
Will need to update the x-bte annotation once the #169 is addressed for all instances ( Can create separate operations depending on status, so we can map it to different predicates during the treats refactor/biolink-model update |
repoDB has been updated on all instances (under the hood, the internal routing is now to biothings.transltr.io - ITRB Prod instance...not biothings.ncats.io). So I'm moving this issue back to a to-do, to update the x-bte annotation. |
Updated the SmartAPI yaml w/ x-bte annotation to match the parser/API updates - master branch only uses the "approved" treatment operations NCATS-Tangerine/translator-api-registry@fa1f36e Also updated the SmartAPI registration. So it's ready to add to BTE's regular use (for the config file, API_LIST variable) - so I added it to the PR linked above. We'll try to get it into Translator's Lobster release (dev/CI -> Test this Friday). There's another version in biolink-4-update biothings/biothings_explorer#788 with "clinical trial only" operations available: NCATS-Tangerine/translator-api-registry@50634e7. I've adjusted the PR biothings/bte-server#19 to add an override to this. |
@colleenXu Should this issue be closed? |
Yep, confirmed that it's live by posting an example query to Example
There should be edges like this that come from repodb
|
Requirement originally discussed in: smartAPI - Issue#85
Plugin repo: https://github.com/erikyao/repoDB
Bug description: Due to the reason explained in this comment, the parser previously (back in 2020) relied on MyChem to query
drugbank.id => drugbank.name
. However since 2021 MyChem no longer providesdrugbank
data (see https://docs.mychem.info/en/latest/doc/data_source.html#drugbank).Solution: find another API for
drugbank.id => drug_name
queries, or pre-process the data filefull.csv
The text was updated successfully, but these errors were encountered: