Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

netlify: Hide deploy preview bar #79

Merged
merged 1 commit into from
Sep 5, 2022
Merged

Conversation

neonfuz
Copy link
Collaborator

@neonfuz neonfuz commented Sep 2, 2022

Hide the bar that appears at the bottom of the netlify previews.

Its features may be slightly useful but I think it's ugly and just gets in the way of normal users.

@netlify
Copy link

netlify bot commented Sep 2, 2022

Deploy Preview for fazeoid ready!

Name Link
🔨 Latest commit 3f3d932
🔍 Latest deploy log https://app.netlify.com/sites/fazeoid/deploys/631265b9bf3c41000974cf07
😎 Deploy Preview https://deploy-preview-79--fazeoid.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@44100hertz
Copy link
Collaborator

Should we really hide this bar?

@neonfuz
Copy link
Collaborator Author

neonfuz commented Sep 4, 2022

A few reasons:

1: it's not that useful. You have to login with netlify, granted you can make a netlify with a github but still it funnels users into making an account. And after that the functionality you get is the same as commenting on github (which gets reposted by the netlify bot). The only useful tool really is the screen recorder which I found a little weird because it recorded the entire window (tabs and all).

2: it's ugly. I don't think it's themeable, and worst of all it covers content. It's set to position absolute so it floats over content and doesn't add scroll height. So I think right now the netlify bar covers the Fazeoid & copyright text at the bottom.

3: right now it's a bit broken on mobile. This will be fixed with #66, but after that the bar will be even bigger and cover more.

4: Removing it makes the app look the same as production, which looks nicer IMO. I suppose it has a downside that someone could mistake it for production, but they would just have to look at the URL to know.

@44100hertz
Copy link
Collaborator

OK

@44100hertz 44100hertz merged commit 2124769 into master Sep 5, 2022
@neonfuz neonfuz deleted the netlify-improve-preview branch September 5, 2022 03:24
44100hertz pushed a commit that referenced this pull request Mar 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants