Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: Create offer flow #108

Merged
merged 5 commits into from
Dec 12, 2024
Merged

UI: Create offer flow #108

merged 5 commits into from
Dec 12, 2024

Conversation

nostrbuddha
Copy link
Contributor

All trade screens are covered just enough, so functional integration can start to happen.

Individual screen elements can be improved much.

 - if Settings.firstLaunch is true. Onboarding screen will be shown.
 - On viewing all slides in Onboarding screen, Settings.firstLanuch is persisted to false

 - Multi screen wizard transitions. Replaced slide with fadeIn/Out

 - Multi screen wizard Topbar.Progressbar fixed

 - Rounded btc display to 8 decimals (KMP logic. Platform specific implementation
 - BispGap

 - Button - Custom text component

 - CurrencyProfileCard - Selectable

 - Multiscreen wizard - Can make use of both Scroll and Static Scaffolds now. Whichever screen needs to use LazyColumn, can now maje use of static

 - Btc - sats display (partial)
@rodvar
Copy link
Collaborator

rodvar commented Dec 11, 2024

rebased against latest main changes

Copy link
Collaborator

@rodvar rodvar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff @nostrbuddha

I've created the following issues to be work separately one-by-one.

Please comment on the ones you would like to tackle yourself and create one PR per issue or one PR that caters for several of them please 🙏 - what is most comfortable for you.

@rodvar rodvar merged commit e38b9e2 into bisq-network:main Dec 12, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants